Fix EvaluationContextImpl constructor compilation errors - #295
Closed
Rikkola wants to merge 1 commit into
Closed
Conversation
Updated EvaluationContextImpl instantiation across DMN FEEL benchmark classes to use the correct constructor signature with FEELEventListenersManager, FEELDialect, and DMNVersion parameters. Also added dependency-reduced-pom.xml to .gitignore to exclude Maven Shade Plugin generated files. Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
@gitgabrio the build was broken, what do you think about this fix? You might know more about the issue. |
Contributor
Author
|
@gitgabrio @yesamer I am not sure if it is bug in DMN or a bug that these tests were just not updated when DMN core changed. |
Contributor
|
@Rikkola the code in the benchmark should not need to change, that's why we want to fix it in kie-dmn core |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apache/incubator-kie-issues#2175
Updated EvaluationContextImpl instantiation across DMN FEEL benchmark classes to use the correct constructor signature with FEELEventListenersManager, FEELDialect, and DMNVersion parameters. Also added dependency-reduced-pom.xml to .gitignore to exclude Maven Shade Plugin generated files.